string_t offer_text;
offer_text += current_offer.invite.game_type == 0 ? "First game type" : (current_offer.invite.game_type == 1 ? "Second game type" : "Third game type");
🎉 Celebrating 25 Years of GameDev.net! 🎉
Not many can claim 25 years on the Internet! Join us in celebrating this milestone. Learn more about our history, and thank you for being a part of our community!
Conditional expression
Author
I don't know is this a bug or not, just want to report:
Author
... and looks like there's another one related to boolean variables handling
in the main script I have a global boolean variable and two little functions
First I call show_offer() via ExecuteString(0, "show_offer()" ...) using my own context.
But after I execute the following code via ExecuteString the variable is not changed!
... since on the next ExecuteString(0, "on_offer_cancelled()", ...) I successfully pass inside "if(showing_offer)" block.
I've changed showing_offer to int32 and now I compare it to 0 or 1 and hopefully everything works as expected. So, it looks like this problem is related to boolean variables only.
in the main script I have a global boolean variable and two little functions
bool showing_offer = false;void show_offer(){ showing_offer = true; // doing something useful...};void on_offer_cancelled(){ if(showing_offer) { // doing some stuff here // ... showing_offer = false; };};First I call show_offer() via ExecuteString(0, "show_offer()" ...) using my own context.
But after I execute the following code via ExecuteString the variable is not changed!
showing_offer = false; net.decline_offer()... since on the next ExecuteString(0, "on_offer_cancelled()", ...) I successfully pass inside "if(showing_offer)" block.
I've changed showing_offer to int32 and now I compare it to 0 or 1 and hopefully everything works as expected. So, it looks like this problem is related to boolean variables only.
That ternary conditional operator has given me a lot of grief, with various bugs in the past. You've likely stumbled upon another bug by chaining the operator like this. You should be able to work around it by using common if-else statements instead.
I'll take a look at the problem with boolean variables as well.
What version of AngelScript are you using?
Thanks,
Andreas
I'll take a look at the problem with boolean variables as well.
What version of AngelScript are you using?
Thanks,
Andreas
That's strange, I thought I had fixed the behaviour of booleans in 2.8.0a. I guess I missed a scenario. I'll try to have it fixed as soon as possible.
Regards,
Andreas
Regards,
Andreas
Author
It looks like something is wrong with ExecuteString, since only ExecuteString does not change global booleans declared in the prebuilt main module. Every function in that module works correctly with booleans then I call it directly or even via ExecuteString.
AddCodeSection(...);
Build(0);
....
ExecuteString(0, "my_var = true; other_func()") - fails to change my_var
ExecuteString(0, "set_var_to_true(); other_func()") - works!
bool my_var = false;void set_var_to_true(){ my_var = true;};void other_func(){};AddCodeSection(...);
Build(0);
....
ExecuteString(0, "my_var = true; other_func()") - fails to change my_var
ExecuteString(0, "set_var_to_true(); other_func()") - works!
I do not think it is directly related to ExecuteString itself, since that script is compiled just like any other function. But I'll definitely test it to see if I can reproduce the problem with ExecuteString.
I'm not able to reproduce the problem.
I wrote the following test:
The global variable gFlag is being updated correctly.
Of course, I'm currently testing with the version in SVN. And I'm using MSVC6.
What compiler are you using?
Can you send me some sample code that reproduces the problem? Or give the version in SVN a try to see if the problem remains?
Regards,
Andreas
PS. Still haven't looked at the conditional operator ?:
I wrote the following test:
static const char *script2 ="bool gFlag = false;\n""void Set() {gFlag = true;}\n""void DoNothing() {}\n";bool Test(){ bool fail = false; int r; COutStream out; asIScriptEngine *engine = asCreateScriptEngine(ANGELSCRIPT_VERSION); engine->SetMessageCallback(asMETHOD(COutStream,Callback), &out, asCALL_THISCALL); RegisterScriptString(engine); engine->RegisterGlobalFunction("void Assert(bool)", asFUNCTION(Assert), asCALL_GENERIC); // TEST 2 engine->AddScriptSection(0, "script", script2, strlen(script2)); r = engine->Build(0); if( r < 0 ) fail = true; int id = engine->GetGlobalVarIDByName(0, "gFlag"); bool *flag = (bool*)engine->GetGlobalVarPointer(id); *(int*)flag = 0xCDCDCDCD; engine->ExecuteString(0, "Set()"); if( *flag != true ) fail = true; engine->ExecuteString(0, "Assert(gFlag == true)"); engine->ExecuteString(0, "gFlag = false; DoNothing()"); if( *flag != false ) fail = false; engine->ExecuteString(0, "Assert(gFlag == false)"); engine->ExecuteString(0, "gFlag = true; DoNothing()"); if( *flag != true ) fail = false; engine->ExecuteString(0, "Assert(gFlag == true)"); engine->Release(); // Success return fail;}The global variable gFlag is being updated correctly.
Of course, I'm currently testing with the version in SVN. And I'm using MSVC6.
What compiler are you using?
Can you send me some sample code that reproduces the problem? Or give the version in SVN a try to see if the problem remains?
Regards,
Andreas
PS. Still haven't looked at the conditional operator ?:
This may be related to the bug fixes I made (and just sent to Andreas tonight). There were aliasing issues that, depending on the compiler and its optimization settings, could cause bugs related to booleans (bytes and words actually). Hopefully my fixes fix the problem you are seeing.
This topic is closed to new replies.
Advertisement
Popular Topics
Advertisement